Requiring Successful Build on Pull Requests RRS feed

  • Question

  • I have been working to set up a release pipeline for my team in VSTS, and recently someone requested that we require a successful build before a pull request can be approved. Even if the build is successful, my understanding is that the deployment should be halted until the pull request has been approved, but that is not what is happening. With the current behavior, code that has not been reviewed via the pull request could proceed to a Production environment without the Pull Request ever being looked at or even rejected. 

    The process that I understood was:

     - Developer commits/pushed code.

     - Developer submits a pull request to have the code reviewed.

     - Reviewer would approve/reject based the Pull Request.

     - If the pull request is approved, the artifacts would be deployed to a testing environment for verification.

    Am I missing something about the available functionality in VSTS, or is this a process problem?

    Monday, December 4, 2017 4:27 PM