The If ... Else.. End if

Question

    Private Sub Calcbut_Click(sender As Object, e As EventArgs) Handles Calcbut.Click
        Dim pass, merit, distinction, overall
        pass = Passbox.Text
        merit = Meritbox.Text
        distinction = Distinctionbox.Text
        overall = pass + merit + distinction


        If overall >= 19 Or overall <= 17 Then
            MsgBox("Theres only 18 Units")
            Passbox.Text = vbEmpty
            Meritbox.Text = vbEmpty
            Distinctionbox.Text = vbEmpty
	End If

Overallbox.Text = (pass * 10 * 7) + (merit * 10 * 8) + (distinction * 10 * 9)

End Sub
End Class

This is a sample of my program, however when "Overall" is = 18, it still throws up the MsgBox instead of skipping the if... What am i doing wrong?
 

Answer 1

Put the following at the top of your form's code:

Option Strict On
Option Explicit On

You'll see some issues shown following that. Correct those then post the revised code.

---

Please call me Frank :)

Answer 2

Your variable overall does not equal 18.  Its not even an integer.  You have dimmed it implicitly as an object, and later assign it the concatenation of 3 different text strings.  So when it hits the If block, overall might be "0180" or "666" or something.  Even if it were the string "18" it still isn't the integer 18 so it would fail the If test.

Answer 3

try this:

dim overall as integer
overall = val(Passbox.Text) + val(Meritbox.Text) + val(Distinctionbox.Text)
 

---

Chuck

Answer 4

try this:

dim overall as integer
overall = val(Passbox.Text) + val(Meritbox.Text) + val(Distinctionbox.Text)
 

---

Chuck

Aside from Val being a horrible method that should have been tossed out years ago - what happens if someone types in "six" rather than "6"?

---

Please call me Frank :)

Answer 5

Ouch Frank!

---

Chuck

Answer 6

Were you able to get it to work?

---

Chuck

Answer 7

In your code replace:

Dim pass, merit, distinction, overall

with this:

 Dim pass As Integer, merit As Integer, distinction As Integer, overall As Integer

It will work, it is working for me just fine :) (VS 2012)

Answer 8

It will work, it is working for me just fine :) (VS 2012)

It will work some of the time.   It will fail if the user enters something into the textbox that is not a valid integer or, more likely, leaves a textbox blank.  You should not assume that a textbox entry can be converted to an integer - it must be tested and confirmed before attempting the conversion.

http://msdn.microsoft.com/en-us/library/f02979c7.aspx

Answer 9

Yes I know, it will throw an exception but he can verify if the inserted text is a number (an integer) before the "if" and if it is not, another msgbox can ask the user to insert a number ... he only asked why the msgbox is fired when the sum is 18 not why it is not working when a user input text in the txtboxes ... the fine tuning is up to him ... or to other people if they want ... may be his form has a label that ask people to insert only integer numbers...