Error Copying Files From Library

Question

I'm working on a script that will copy files from a SP library to a file share, then delete the files from the library.  The script works great, except for one spot.  It will copy the first document from the library and delete, but then throws an exception:

An error occurred while enumerating through a collection: Collection was modified; enumeration operation may not execute..
At C:\Scripts\AuditLogArchive\Archive-AuditLogs.ps1:47 char:16
+         foreach <<<<  ($file in $files)
    + CategoryInfo          : InvalidOperation: (Microsoft.Share...on+SPEnumerator:SPEnumerator) [], RuntimeException
    + FullyQualifiedErrorId : BadEnumeration

Here is how I'm doing it:

    foreach ($site in $sites)
    {
        try
        {
            $web = Get-SPWeb $site.Url
            #$site.Dispose()
            
            $lib = $web.GetFolder("Audit Logs")
            
            if ($lib.ItemCount -ne 0)
            {
                Write-Host "Archiving Site: " $site.Url
                $files = $lib.Files
            }
            else
            {
                #Write-Host "Nothing to archive"
                Continue
            }
        }
        catch
        {
            Write-Host "Unable to get files from audit log library"
            Continue
        }
        
        # Download files from SharePoint to TemPath
        foreach ($file in $files)
        {
            Write-Host $file.Name
            $bytes = $file.OpenBinary()
            
            $temp = "$tempPath\"+$file.Name
            
            try
            {
                $stream = New-Object System.IO.FileStream($temp, "Create")
                $writer = New-Object System.IO.BinaryWriter($stream)
                $writer.write($bytes)
            }
            catch
            {
                Write-Host "Unable to copy "$file.Name" to $temp"
                Write-Host $_.Exception.Message
            }
            finally
            { 
                $writer.Close() 
            }
}

Any ideas what I'm doing wrong?

Answer 1

Hello,

This is happening because you are trying to modify the collection while still enumerating.

I suggest you, don't delete under the same loop.

Instead use some variables to store references and then delete them

---

For anything related to SharePoint https://www.fiverr.com/rashu268

Answer 2

Hi JedLO,

For troubleshooting the issue, you could check things below:

1. Check if the brackets are matching in your script.

2. Use a for-loop instead of foreach.

Best regards,

Sara Fan

---

TechNet Community Support
Please remember to mark the replies as answers if they help, and unmark the answers if they provide no help. If you have feedback for TechNet Support, contact [e-mail].

Answer 3

Hi JedLO,

How is everything going?

Is there anything update about this issue?

If the reply is helpful to you, you could mark the reply as answer. Thanks for your understanding.

Best regards,

Sara Fan

---

TechNet Community Support
Please remember to mark the replies as answers if they help, and unmark the answers if they provide no help. If you have feedback for TechNet Support, contact [e-mail].

Answer 4

That did the trick. Using one loop to collect the item id's and another to copy the items doesn't throw an exception. Thanks!

Answer 5

Hi JedLO,

It is very happy that you have resolved the problem.

Thank you for your sharing and it will help others have the same issue.

Best regards,

Sara Fan

---

Please remember to mark the replies as an answers if they help and unmark them if they provide no help.
If you have feedback for TechNet Subscriber Support, contact [e-mail]