User627490255 posted
Hi all, i have a webapp my brother in law helped me build it (well he did it all..then has largely left me too it), i am new to programming c#, http, css etc. ai have a little sporadic experience with python and vb,net.
anyway, i have an 'object not set to an instance of an object error when submit button is hit.
i have noted where the code resides.
In views/incident/editincident.cshtml
@model CareHomeForms.Models.EditIncidentViewModel
<!-- The heading title for the page -->
<div class="row">
<div class="col-sm-12">
<h1>Report a new incident</h1>
</div>
</div>
<div class="row">
<div class="col-sm-12">
<h2 class="alert">General Details</h2>
</div>
</div>
<div class="row">
<div class="col-sm-12">
<form action="@Url.Action("EditIncident","Incident")" method="post" class="form-horizontal">
@Html.AntiForgeryToken()
<div class="form-group">
<label for="IncidentNumber" class=" control-label col-sm-3">Incident Number</label>
<div class="col-sm-1">
<input type="text" name="IncidentNumber" id="IncidentNumber" value="@Model.IncidentNumber"
readonly class="form-control" data-toggle="popover"
data-content="Generated Automaticaly"
data-trigger="focus" data-placement="top" />
</div>
</div>
<div class="form-group">
<div class="col-sm-12">
<button type="submit" name="Submit" class="btn btn-success pull-right">Create Incident</button>
</div>
</div>
<div class="form-group">
<div class="col-sm-12">
<a href="@Url.Action("","")" class="btn btn-default">Cancel & Return To Home Page</a>.
</div>
</div>
</form>
In root of controlers folder
using CareHomeForms.Models;
using CareHomeForms.Services.Data;
using CareHomeForms.Services.Data.Models;
using Microsoft.AspNetCore.Mvc;
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using Microsoft.AspNetCore.Authorization;
namespace CareHomeForms.Controllers
{
[Route("incident")]
public class IncidentController : Controller
{
private ICareHomesDb db;
public IncidentController(ICareHomesDb db)
{
this.db = db;
}
[Route("New")] // The name of the function
[HttpGet]
[Authorize(Roles = "admin")]
public ActionResult NewIncident(EditIncidentViewModel viewModel, string id = null) // what is passed to it in brackets
{
var newId = id ?? Guid.NewGuid().ToString(); // generate a new guid for the new form
return RedirectToAction("EditIncident", new {incidentId = newId}); // this redirects to another function 'editincident' with the viewmodel and new id
}
[Route("{incidentId}/edit")]//request received for the incident report form
[HttpGet]
public async Task<ActionResult> EditIncident() //The view name
{
var employeeResults = await db.GetPeopleAsync(PersonType.Employee);
var employees = employeeResults.ToList();
employees.Insert(0, new Person());
var residentsResults = await db.GetPeopleAsync(PersonType.Resident);
var residents = residentsResults.ToList();
residents.Insert(0, new Person());
var viewModel = new EditIncidentViewModel
{
IncidentNumber = "1234",
Staff = ToIdentifiedPerson(employees),
Residents = ToIdentifiedPerson(residents)
};
return View(viewModel);
}
//// This action will respond to a POST request from a form being submitted
[Route("{incidentId}/edit")]
[HttpPost] //do something when a form has been sent (posted) back
[ValidateAntiForgeryToken]
public async Task<ActionResult> FormSubmitted(EditIncidentViewModel viewModel, string returnUrl = null)
{
bool isUpdate = true;
var incident = await db.GetIncidentFormByIdAsync(viewModel.Incident.Id);
if (incident == null)
{
incident = viewModel.Incident;
incident.Version = 1;
incident.IsDraft = false;
}
else
{
isUpdate = false;
}
incident.LastUpdated = DateTime.UtcNow;
incident.Author = "5E5D44AF-2B72-4F7D-AC95-F99530E2752D";
await db.SaveIncident(incident, isUpdate);
return RedirectToAction("FormSubmitted", new { viewModel.Incident.Id, returnUrl });
}
In root of models folder
using System;
using System.Collections.Generic;
using System.Linq;
using System.Threading.Tasks;
using CareHomeForms.Models;
using CareHomeForms.Services.Data.Models.FormModels;
namespace CareHomeForms.Models
{
public class EditIncidentViewModel
{
public List<IdentifiedPerson> Staff { get; set; }
public Incident Incident { get; set; }
public List<IdentifiedPerson> Residents { get; set; }
public string IncidentNumber { get; set; }
public string IncidentId { get; internal set; }
public string Id { get; internal set; }
public string ReportingStaffId { get; set; }
public bool IsUpdate { get; set; }
}
}
Any help with this error appreciated:-)
Error – NullReferenceException: Object reference not set to an instance of an object. • CareHomeForms.Controllers.IncidentController.FormSubmitted(EditIncidentViewModel viewModel, string returnUrl) in IncidentController.cs + 67. var incident =
await db.GetIncidentFormByIdAsync(viewModel.Incident.Id);
cheers
steve
