The regular expression takes this input:
"SJDC-12345678912345678"
Basically, it's 4 characters followed by "-" and then 16 numbers
The sample does not match the requirement.
This
^[A-Z]{4}-[1-9]{16}$
matches
SJDC-1234567891234567
https://regex101.com/
Try this
^[A-Z]{4}-[\d]{16}$