How do I modify my code to work ?

Question

        void  SimpleTextRenderer::libgetclick()
        {
 int wurd;
            int cx, dx;

	FileOpenPicker^ openPicker = ref new FileOpenPicker();
    openPicker->ViewMode = PickerViewMode::Thumbnail;
	openPicker->SuggestedStartLocation = PickerLocationId::DocumentsLibrary;
    openPicker->FileTypeFilter->Append(".slb");

	create_task(openPicker->PickSingleFileAsync()).then([this](StorageFile^ file)
        {
            if (file)
            {
             create_task(file->OpenAsync(FileAccessMode::Read)).then([this, file](IRandomAccessStream^ readStream){
	
		DataReader^ dr = ref new
		DataReader(readStream); //requires input stream



		create_task(dr->LoadAsync((UINT)readStream->Size));
			  
		int cx,di,si,wurd;	
		wurd=0;
            di = 1;
readlp:
            wurd = (UINT16)rev(dr->ReadInt16());
			        
				if (wurd == 65535)
                goto endreadlp;

            slibrary[di] = wurd;
            di = di + 1;

            //{data. 1 already done!}
            for (cx = 1; cx <= (schdefdatawidth - 1); cx++)
            {
                wurd = (UINT16)rev(dr->ReadInt16());
                slibrary[di] = wurd;
                di = di + 1;
            }



            //{name}
        repeat9:
            wurd = (UINT16)rev(dr->ReadInt16());
            slibrary[di] = wurd;
            di = di + 1;
            if (wurd != 255)
                goto repeat9;



            //{tracks}
        repeat10:
            wurd = (UINT16)rev(dr->ReadInt16());
            slibrary[di] = wurd;
            di = di + 1;
            if (wurd != 65535)
                goto repeat10;


        //{text}
        textlp:
            wurd = (UINT16)rev(dr->ReadInt16());
            slibrary[di] = wurd;
            di = di + 1;
            if (wurd == 65535)
                goto endtextlp;

            for (cx = 1; cx <= (textdatawidth - 1); cx++)
            {
                wurd = (UINT16)rev(dr->ReadInt16());
                slibrary[di] = wurd;
                di = di + 1;
            }

        repeat12:
            wurd = (UINT16)rev(dr->ReadInt16());
            slibrary[di] = wurd;
            di = di + 1;
            if (wurd != 255)
                goto repeat12;


            goto textlp;
        endtextlp:

            //{pads}
        repeat13:
            wurd = (UINT16)rev(dr->ReadInt16());
            slibrary[di] = wurd;
            di = di + 1;
            if (wurd != 65535)
                goto repeat13;


        //{connections}
        conlp:
            wurd = (UINT16)rev(dr->ReadInt16());
            slibrary[di] = wurd;
            di = di + 1;
            if (wurd == 65535)
                goto endconlp;

            for (cx = 1; cx <= (SCHCONDATAWIDTH - 1); cx++)
            {
                wurd = (UINT16)rev(dr->ReadInt16());
                slibrary[di] = wurd;
                di = di + 1;
            }

        repeat14:
            wurd = (UINT16)rev(dr->ReadInt16());
            slibrary[di] = wurd;
            di = di + 1;
            if (wurd != 255)
                goto repeat14;


            goto conlp;
        endconlp:

            //{sepers}
        repeat15:
            wurd = (UINT16)rev(dr->ReadInt16());
            slibrary[di] = wurd;
            di = di + 1;
            if (wurd != 65535)
                goto repeat15;



            //{refs}
        repeat16:
            wurd = (UINT16)rev(dr->ReadInt16());
            slibrary[di] = wurd;
            di = di + 1;
            if (wurd != 65535)
                goto repeat16;



            // {sub symbol delimiter}
            wurd = (UINT16)rev(dr->ReadInt16());
            slibrary[di] = wurd;
            di = di + 1;
            goto readlp;

        endreadlp:
            slibrary[di] = 65535; //{end marker}
            //result = 1;//{loaded ok}
			  });
            }
            else
            {
                ;
            }
        });
    	
auto boxOK =
        ref new Windows::UI::Popups::MessageDialog("Loaded ok");
    boxOK->ShowAsync();


	







		}

---

n.Wright

Answer 1

What is the problem with your code?

Answer 2

What is the problem with your code?

It keeps crashing out with exceptions.

Access denied to memory location.

---

n.Wright

Answer 3

Ok, A couple of issues:

1) make sure you have a continuation after: create_task(dr->LoadAsync((UINT)readStream->Size));

That's an async operation.

Something like:

        return dr->LoadAsync((unsigned int) stream->Size);

    }).then([this, dr] (task<unsigned int> bytesLoaded)

    {

                …

2) Try to refactor your code, it is very difficult to follow it. Get rid of all those gotos
3) Make sure the the value of 'di' is in range when accessing 'slibrary' by index: slibrary[di]

Answer 4

I eventually found a code snippet online that worked.

My problems were compounded by using messageboxes that were running async and interfering with the disc system.

---

n.Wright