Convert nested for each into single LINQ statement

Question

 Hi,

I am new to LINQ to object, could anybody help in me converting below code into single LINQ statement.

foreach (DataRow objRow in objData.Rows)

{

    foreach (var objComment in colComment) {

     if(objComment.Code == objRow["Text"].ToString())

     {

        

objComment.Code = Convert.ToString(objRow["IdField"]);

        

objComment.Desc = Convert.ToString(objRow["Text"]);

         break;

}

}

Thanks in Advance....

Answer 1

This is a case where I would recommend keeping your foreach loop - at least the outer one.  LINQ is not intended for use when  you're creating side effects (setting values), but rather for queries.

You could convert the inner loop into a query, and then loop over the results - but I doubt it would be more clear:

foreach (DataRow objRow in objData.Rows)
{
    var commentsToEdit = colComment.Where(o => o.Code == objRow["Text"].ToString());

    foreach(var objComment in colComment)
    {
       objComment.Code = Convert.ToString(objRow["IdField"]);
       objComment.Desc = Convert.ToString(objRow["Text"]);
    }
}

While there are solutions using ToList().ForEach(...), I would not recommend them.  For details as to why, see: http://blogs.msdn.com/b/ericlippert/archive/2009/05/18/foreach-vs-foreach.aspx

---

Reed Copsey, Jr. - http://reedcopsey.com
If a post answers your question, please click "Mark As Answer" on that post and "Mark as Helpful".

Answer 2

Thanks Reed Copsey