Visual Studio Code Analysis and Code Metrics Forum

VS 2010 Beta 2: CA2135 & CA2118

Mon, 23 Nov 2009 03:16:31 Z

The following code passed code analysis in VS 2008 SP 1:

    [SecurityPermission(SecurityAction.LinkDemand, UnmanagedCode = true)]
    public static class MarshalHelpers
    {
        public static void FillMemory(IntPtr buffer, int bufferSize, byte value)
        {
            NativeMethods.FillMemory(buffer, (IntPtr)bufferSize, value);
        }

        public static void ZeroMemory(IntPtr buffer, int bufferSize)
        {
            NativeMethods.ZeroMemory(buffer, (IntPtr)bufferSize);
        }

        [SuppressUnmanagedCodeSecurity]
        private static class NativeMethods
        {
            [DllImport("kernel32.dll", SetLastError = true)]
            public static extern void FillMemory(IntPtr destination, IntPtr length, byte fill);

            [DllImport("kernel32.dll", SetLastError = true)]
            public static extern void ZeroMemory(IntPtr destination, IntPtr length);
        }
    }

However, with VS 2010 Beta 2 and I get 'CA2135: Level 2 assemblies should not contain LinkDemands' against the MarshalHelpers class - so I replace the LinkDemand with SecurityCritical as follows:

    [SecurityCritical]
    public static class MarshalHelpers
    {
        public static void FillMemory(IntPtr buffer, int bufferSize, byte value)
        {
            NativeMethods.FillMemory(buffer, (IntPtr)bufferSize, value);
        }

        public static void ZeroMemory(IntPtr buffer, int bufferSize)
        {
            NativeMethods.ZeroMemory(buffer, (IntPtr)bufferSize);
        }

        [SuppressUnmanagedCodeSecurity]
        private static class NativeMethods
        {
            [DllImport("kernel32.dll", SetLastError = true)]
            public static extern void FillMemory(IntPtr destination, IntPtr length, byte fill);

            [DllImport("kernel32.dll", SetLastError = true)]
            public static extern void ZeroMemory(IntPtr destination, IntPtr length);
        }
    }

But then I get 'CA2118: Review SuppressUnmanagedCodeSecurityAttribute usage' against NativeMethods.FillMemory & NativeMethods.ZeroMemory, which is what the previous LinkDemand was for. My understanding is that SecurityCritical replaces the functionality of the LinkDemand, so is this a bug, or am I missing something? (Adding back the LinkDemand, but keeping the SecurityCritical attribute, trips CA2135 against the MarshalHelpers class again.)

Why does't the stand-alone FxCop have maintainability and reliability rules ?

Fri, 27 Nov 2009 06:15:19 Z

In past thread , Mr. Brahmnes Fung said "VSTS 2005 have maintainability and reliability rules and the standalone FxCop don't have these rules".
Why does't FxCop have them ?

command line argument

Thu, 26 Nov 2009 08:34:16 Z

How can I pass an argument to a custom made FxCop rule.

For ex:

FxCopCmd.exe /f:"files.dll" /o:"Out.xml" /r:-"Rules.dll" /myargument:true/false

How do I pop up the MSDN page for a CAxxxx violation in Visual Studio?

Thu, 26 Nov 2009 11:03:03 Z

Hi there!

I 've integrated FxCop into my csprojs using the MSBuild Community FxCop task, so I get all my fxcops in the Visual Studio error list panel together with the compiler messages. NB I actually do *not* use an fxcop project and fxcop stand-alone gui

The only thing I really miss in VS is the ability to just click F1 on the message entry and pop up the MSDN page for the CAxxxx violation

Does anyone have any idea of how this could be done? It would make the usage experience more pleasant for the team, which means more needed love for FxCop :-)

Any advice much appreciated!

How to adapt the ImplementIDisposableCorrectly rule ?

Wed, 25 Nov 2009 09:17:11 Z

Hi all,

when i'm using the ImplementIDisposableCorrectly rule, it detects some errors that in my particular case should not be detected.

for example, this code :

public class MyClass : IDisposable
    {
        public void Dispose()
        {
            Dispose(true);
            GC.SuppressFinalize(this);
        }

        protected virtual void Dispose(bool disposing)
        {
        }        
    }

    public static class Disposing
    {
        public static void Dispose<T>(ref T obj) where T : IDisposable
        {
            obj.Dispose();
            obj = default(T);
        }
    }

    public class TestClass : IDisposable
    {
        private MyClass _myclass = new MyClass();

        public void Dispose()
        {
            Dispose(true);
            GC.SuppressFinalize(this);
        }

        protected virtual void Dispose(bool disposing)
        {
            if (disposing)
                Disposing.Dispose(ref _myclass);
        }
    }

is detects as bad one.

So I would like to adapt this rule (tried to derive, but class is sealed) to detect my special case and allow it.

How can I do that ?
Thanks in advance for your help

Best regards

Error Code: 0x80072EE6

Wed, 25 Nov 2009 11:49:19 Z

What are the reasons of exception thrown with error code 0x80072EE6 ?

Analysis in generated code

Mon, 23 Nov 2009 10:33:35 Z

Hi all,

I would like to analyse some parts of the generated code (dataset for example).
So I've unchecked the "suppress analysis results against generated code".

But this code violates many rules and I would like to run the analysis on this generated code ONLY for my custom rule.
Is there a way to run through the generated code only for one custom rule ?

Thanks in advance for your help,
Best regards.

CA0055 error in VS2010 beta 2 - Will Visual Studio 2010 support FxCop for Silverlight?

Mon, 23 Nov 2009 11:42:56 Z

Hi there,

Apologies if this has already been asked + answered (I've looked, but couldn't find it): will FxCop be supported on Silverlight (3 or 4) in Visual Studio 2010?

We currently use Silverlight 3 with Visual Studio 2008, and make very heavy use of FxCop: we have several of our own custom rule assemblies and rely upon the whole process to keep ourselves in check.

Visual Studio 2010 beta 2 gives a CA0055 error when we switch Code Analysis on for a Silverlight assembly, saying that analysis of Silverlight assemblies is not supported.

Is this a beta 2 limitation or is there a plan to stop supporting FxCop for Silverlight assemblies for the final 2010 release? (That would be a massive shame: one of the reasons for using Silverlight over something like Flex is that we get much better developer tool support...)

Cheers,
Royston.

Royston Shufflebotham

fxcop code review utility Version 1.36 vs Version 1.35

Mon, 23 Nov 2009 06:18:49 Z

Please tell me exact Implementation & Other differences between FXCop 1.35 & FXCop 1.36.

CA2217: Not working properly for 64-bit enums

Tue, 07 Jul 2009 23:11:37 Z

I've been working on making some of the C# projects on my team FxCop compliant. I recently encountered a weird bug with CA2217. There is a particularly large flag enum that keeps triggering the warning, despite being valid.

<Example>

[Flags]
public enum Values : long
{
    Value1 = 0x1 << 0,
    Value2 = 0x1 << 1,
    ...
    Value32 = 0x1 << 31,
    Value33 = 0x1 << 32,
    Value34 = 0x1 << 33
}

</Example>

The above results in the following CodeAnalysis warning:

Warning CA2217 : Microsoft.Usage : 'Values' is marked with FlagsAttribute but a discrete member cannot be found for every settable bit that is used across the range of enum values. Remove FlagsAttribute from the type or define new members for the following (currently missing) values: 0x80000000, 0x100000000, 0x200000000, 0x400000000, 0x800000000, 0x1000000000, 0x2000000000, 0x4000000000, 0x8000000000, 0x10000000000, 0x20000000000, 0x40000000000, 0x80000000000, 0x100000000000, 0x200000000000, 0x400000000000, 0x800000000000, 0x1000000000000, 0x2000000000000, 0x4000000000000, 0x8000000000000, 0x10000000000000, 0x20000000000000, 0x40000000000000, 0x80000000000000, 0x100000000000000, 0x200000000000000, 0x400000000000000, 0x800000000000000, 0x1000000000000000, 0x2000000000000000, 0x4000000000000000, 0x8000000000000000

   This seems like a particularly strange suggestion, and when I change the last entries to be within the size of int everything works fine. Is there a known bug with this rule and long enums?

A noise from static analyzer on standard headers (shobjidl.h and atldbcli.h)?

Fri, 13 Nov 2009 20:12:52 Z

Here is a problem with my project:
If I compile any solution configuration (Debug or Release) for the Win32 platform with "/analyze" I get the next warnings:
a)
3>$(WindowsSdkDir)\include\shobjidl.h(32803) : warning C6387: '*ppv' might be '0': this does not adhere to the specification for the function 'SHLoadLibraryFromItem': Lines: 32805, 32806, 32807, 32808, 32817
3>$(WindowsSdkDir)\include\shobjidl.h(32820) : warning C6387: '*ppv' might be '0': this does not adhere to the specification for the function 'SHLoadLibraryFromKnownFolder': Lines: 32822, 32823, 32824, 32825, 32834
3>$(WindowsSdkDir)\include\shobjidl.h(32837) : warning C6387: '*ppv' might be '0': this does not adhere to the specification for the function 'SHLoadLibraryFromParsingName': Lines: 32839, 32840, 32841, 32842, 32847
3>$(WindowsSdkDir)\include\shobjidl.h(32880) : warning C6387: '*ppszResolvedPath' might be '0': this does not adhere to the specification for the function 'SHResolveFolderPathInLibrary': Lines: 32882, 32883, 32884, 32885, 32902
3>$(WindowsSdkDir)\include\shobjidl.h(32905) : warning C6387: '*ppszSavedToPath' might be '0': this does not adhere to the specification for the function 'SHSaveLibraryInFolderPath': Lines: 32907, 32909, 32912, 32913, 32914, 32928

b)
3>$(VCInstallDir)\atlmfc\include\atldbcli.h(4583) : warning C6011: Dereferencing NULL pointer 'm_pColumnInfo': Lines: 4541, 4542, 4543, 4544, 4547, 4548, 4552, 4554, 4555, 4556, 4559, 4560, 4563, 4568, 4570, 4572, 4575, 4577, 4578, 4579, 4583
3>$(VCInstallDir)\atlmfc\include\atldbcli.h(6165) : warning C6011: Dereferencing NULL pointer 'pPropSets+i': Lines: 6146, 6148, 6149, 6150, 6152, 6153, 6156, 6158, 6159, 6160, 6162, 6164, 6165

For convenience, I replaced all physical file system paths with VS macros. Modification date of the shobjidl.h file is 2009-07-14, ‏‎19:53:48; atldbcli.h -- 2007-07-09, ‏‎16:32:24.

My configuration is:
* Visual Studio Team System 2008 Service Pack 1 ENU (cl.exe -- 15.00.30729.01 for 80x86);
* Some defines from properties sheet: /D "PLATFORM_WIN32" /D "NTDDI_VERSION=NTDDI_WIN7" /D "_WIN32_WINNT=_WIN32_WINNT_WIN7" /D "WINVER=0x0601";
* Windows SDK for Windows 7 (7.0), AMD64;
* Windows DDK 7.0.0.7600;
* Windows 7 Ultimate x64.

I believe compiler is right. For example, "$(WindowsSdkDir)\include\shobjidl.h(32803) : warning C6387: ..." points to incorrect "__deref_out" annotation (__deref_out_opt should be used?).
So, in any case: what's wrong? Is this a "static analyzer noise" or is this my mistake?

Thanks!

Find method that call constructor

Wed, 18 Nov 2009 16:56:51 Z

Hi all,

I've this code to test :

public class MyClass
{
    public void Foo()
    {
        Console.WriteLine("foo");
    }
}
public class MyClass2
{
    public void Foo()
    {
        Console.WriteLine("foo");
    }
}
public class Test
{
    public void Do()
    {
        MyClass c = new MyClass();
        c.Foo();
    }
    public void Do2()
    {
        MyClass2 c = new MyClass2();
        c.Foo();
    }
}

i'm overriding the VisitConstruct to find specific call to new and I would like to know the calling method.

public override void VisitConstruct(Construct construct)
{
    if (construct.Type.Name.Name == "MyClass")
    {
        // here I want to test the calling method, i.e : Do()
    }
    base.VisitConstruct(construct);
}

How can I do that ?

Thanks in advance for any help,
Best regards

Can Microsoft FxCop 1.36 be used with VS2010 Beta 2?

Thu, 19 Nov 2009 15:06:49 Z

I am developing on VS2010 Beta 2 targetting Framework 4.0. Can I use FxCop 1.36?

Code Analysis for Windows CE Application Development

Thu, 19 Nov 2009 11:35:21 Z

Hiya,

I'm a Windows CE developer and I've been using PREfast for a while via platform builder (via Visual Studio 2005 Pro). This has been fine, but I'm now also working with our application development team building quite a complicated app. I've looked to see how I can enable code analysis for the app, but I'm utterly stumped.

I should add that I looked at the video demo of VS2005 that shows going to :
Properties > Confugration Properties > C/C++ / Advanced / Enable PREfast

but this doesn't appear in visual studio for me. I get the impression that this may be a "Team system" specific thing, but obviously Windows CE Platform Builder ships with, and is validated with the 'pro' edition and already has the PREfast functionality so I'm a bit confused...

I've tried manually adding /analysis and /analyze:WX but the compiler now thinks these are unknown switches. Does this mean somehow VS2005 uses a different version of the compiler when building the apps apart from the platform? Can someone suggest how I can get around this?

Cheers,

~Pev

PREfast doesn't support uninitialized array check?

Mon, 09 Nov 2009 07:50:08 Z

Just found that PREfast for Windows CE5 and CE6 (integrated) doesn't support the check of uninitialized array which coverity supports. For example:

int result;
int uninit_array() {
    int x[4];
    result = x[1]; // defect: use of uninitialized array member x[1]
}

Do you have plan to support this check in future?

Thanks,

Dong

Help with CA0060

Mon, 16 Nov 2009 05:01:26 Z

I'm trying to work through a CA0060 error which is causing a build break. The specific error is below, if it matters. I tried adding StrongNameIgnoringVersion as other threads have suggested, but no luck.

Is there anything else I can try?

20>MSBUILD : error : CA0060 : The indirectly-referenced assembly 'System.Data, Version=2.0.0.0, Culture=neutral, PublicKeyToken=b77a5c561934e089' could not be found. This assembly is not required for analysis, however, analysis results could be incomplete. This assembly was referenced by: 'System.Data.SqlServerCe.dll'.

How to Run StyleCop Automatically After Build?

Sat, 14 Nov 2009 09:49:27 Z

I have installed StyleCop and I can run it manually using the Tools menu in VS. I'd want to run StyleCop automatically after my class library project is built.

Do you know any macro that can be placed in the "Port-Build Event" section of my Project Properties page which would make the StyleCop run?

I placed this macro:

"%ProgramFiles%\Microsoft StyleCop 4.3.2.1\StyleCopSettingsEditor.exe" "$(ProjectDir)/Settings.StyleCop"

But it only opens the StyleCop rule management window without really running it.

Any thoughts?

Thanks,

Share code analysis rules between team projects

Tue, 17 Nov 2009 17:13:08 Z

Hi.
I have multiple team projects, and I want to apply Code Analysis check-in policy for them.
How can I declare a set of rules I want to check, and share it between the team projects? Is there an Import/Export option?

I already configured the set of rules I want to run using standalone fxcop. Can I upload it into my TFS?

Thanks,
Sagie

Code metrics for unmanaged C++ code?

Wed, 08 Oct 2008 10:15:53 Z

Does code metrics in Visual Studiu 2008 Tema System work for unmanaged C++ code?

Error: FxCop appears to have hung or deadlocked

Wed, 04 Nov 2009 07:22:59 Z

Hi,

We are using FxCop for Code Analysis.
When we build the project in visual studio 2008, we get the following build error saying "FxCop appears to have hung or deadlocked".

Pragma not working for warning CA1502?

Sun, 15 Nov 2009 02:02:59 Z

Sirs,

I'm trying to disable the warning CA1502 from a method. When I try to:

#pragma warning disable 1502

The visual studio 2008 SP1 says that the 1502 number is not a recognized warning.

Any help?

Regards

Camilo

Supress warning on caller assembly

Thu, 12 Nov 2009 05:58:20 Z

Hi all, i have two extension methods like this:

public static bool IsDateTime(this string source) {
	return (IsDateTime(source, CultureInfo.InvariantCulture));
}

public static bool IsDateTime(this string source, IFormatProvider provider) {
	DateTime tempDate;
	if(DateTime.TryParse(source, provider, DateTimeStyles.None, out tempDate)) {
		return (true);
	}
	return (false);
}

Now every time someone call the first overload they get a SpecifyIFormatProvider warning.
Is there a way to avoid this warning on the caller?, in this case I can think it does not matter which overload gets called.

Thanks for your time.

Juan Zamudio

Custom rule to check if we always use the return value

Thu, 05 Nov 2009 07:59:55 Z

Dear all,
I'm trying to do a custom code analysis rule that would detect if all methods that returns a certain type use that return value.
For eg, I've a custom class called "MyPersonalStatusCode".
Some of my methods return that object:
public MyPersonalStatusCode MyPublicMethod (){};

I want to raise a warning if I do:

// some code
MyPublicMethod ();

instead of:
MyPersonalStatusCode myreturnValue = MyPublicMethod ();

I've already managed to find the methods that returns my class, but I dont know how to check if the return value is used or not.
Any pointers that could lead me to a solution?

Thank you very much,

[FxCop 1.36, Custom rule] How to find all references to an specific node?

Fri, 06 Nov 2009 07:47:50 Z

Hello!
Is it possible to find all references to concrete node (caller/callee list, field load/store, delegate creation etc) without manual enumerating over all statements?

Sample simple rule to represent scenario:
Restrict load/store of fields if they're exposed via property getter/setter respectively.

It seems, there will be two-phase run:
1) override check on TypeNode: iterate over all properties and store fields they're exposing
2) override check on member: store current member and visit all statements of each. If member references exposed field - there's an problem.

What did I miss? Would it be thread-safe?

Also, is there good manual except one at http://www.binarycoder.net/? It's quite untrivial to drill through FxCop code model.

Code metrics and VC++ projects

Wed, 21 Nov 2007 19:24:24 Z

Why is it that all the menu items for code metrics are present and run for VC++ projects when the feature does not work for unmanaged code?

Analyze FileZilla with Microsoft FxCop 1.36

Tue, 03 Nov 2009 14:36:31 Z

Hi, I tried to analyze the software security of "FileZilla Server" using Microsoft FxCop 1.36. Firstly, I installed FxCop as a stand-alone application, than I opened the FxCop.exe file and rightclicked the "myFxCop Project" chose "Add targets" and searched for the exe file in the build folder of FileZillaServer. After I found it and selected, I have got an error message saying: "No engine was able to load target FileZillaServer.exe". What does this message mean? Is it possible that FileZillaServer is not a .NET application, though it can be compiled in Visual Studio.

Code Anaylysis Tab is not shown

Wed, 04 Nov 2009 05:43:09 Z

Hi
I installed Visual Studio Team System and I chose everything in Feature Selection step, but still I don't have Code Analysis tab shown in Project/Properties page, and I also don't have it installed, because I can't see it either in Project menu or in the project context menu. I checked the registery, it seems that it is not installed on my computer. Is there any installation pack available for installing Code Analysis and Code Metrics features.

Thank you all.

Trouble with MethodCall Operands in FxCop 1.36

Thu, 29 Oct 2009 03:12:11 Z

I am writing an FxCop rule that tries to find all method calls to a specific logging API. It tries to verify that a number of the parameters to this call are literals, and produces documentation for all the calls made.

For the most part, checking that Operands on the MethodCall object are Literal instances does the trick just fine, but I get into trouble when an overload with a 'params object[] arguments' is used. As soon as the 'params' occur, *all* arguments to the call are only reported back as 'NodeType.Pop'.

I found a post somewhere that discussed walking the 'Instructions' and using a call to 'RuleUtilities' to walk backwards over the arguments from the call site, but this API call appears to have been discontinued in 1.36, so that is not helping me either.

Is there any way to find the method argument literal values in this scenario that does not involve completely custom-writing the method walking/method stack analysis code?

Ignore casing problem globally

Mon, 02 Nov 2009 14:39:11 Z

Hi!
I have a word that I use to name stuff which I want to be in capital letters. Actually I have external requirement to be all capitals. I hate it, but anyway.
Example: FirstWORD or Project.WORD.Class or WORDItem etc.

I don't want to completely disable 1709 rule.
Rules are configured in an external 'targets' file which is referenced by all the projects. CodeAnalysisDictionary cannot help since it's contents are not case sensitive.
GlobalSuppressions file is one solution but this would require this to be made in all projects (except if I use linked files). The main problem with this solution is Target property of System.Diagnostics.CodeAnalysis.SuppressMessage. You have to define this attribute almost for each violation of the rule.

Any better ideas?

Dimitris Papadimitriou, Software Development Professional

Static code analysis not available in one VS2008 installation

Thu, 17 Sep 2009 14:13:33 Z

Hello everybody,

we use VS2008 Team Edition for Developers here, running von Vista Enterprise x64 including all patches of course. On one machine, static code analysis is simply not available. Neither the user interface in the project properties includes the "code analysis" tab, nor does fxcop run on building projects for which code analysis is enabled.

Where could we check what is missing? VS setup just displays everything is installed. Is there some repair option? Is an uninstall/reinstall cycle necessary? Any help is greatly appreciated of course.

Best Regards,
Stefan FAlk

Stefan Falk

Restricting Code Analysis Errors Suppression

Tue, 03 Nov 2009 09:48:54 Z

Hi All,

We do Code Analysis for our solution in VSTS. And of course, we suppress few errors as applicable. However, at this point anybody from my team (senior or junior) can suppress errors. Is there any way that I can restrict as to who can suppress?

Thanks in advance,
Pavan

Detecting String Literals with FxCop 1.36

Mon, 12 Oct 2009 19:12:01 Z

Hello,

I will just describe my desired result: I need to be able to detect string literals in my project. I could simply just look for every "ldstr" instruction and report a problem, but I need to ignore a string literal if it's passed into a special method (e.g. "Strings.Ignore(System.String)" where the return type is "System.String"). I tried looking for every "ldstr" and then tracing the instructions to see if they eventually called the ignore method, but I think I made too many assumptions (or not enough). It was creating false positives, or not ignoring certain strings. I don't know IL or FxCop 1.36 too well, and I can't seem to find examples of this.

Just to add more information, I should be able to ignore the following "ldstr" instructions:

byte[] array = new byte[]{0,1,2,3,4,5,6,7,8};

string a = string.Format(Strings.Ignore("Format: {0}"), 5);
string b = Strings.Ignore("Ignore this");
string c = string.Format(Strings.Ignore("{0}{1}{2}"), m_Int, m_Bool, m_Float);
string d = Strings.Ignore("Array has: " + array.Length + " elements.");

Basically, anytime ANY string literal is passed into the Strings.Ignore method, it needs to be ignored. Otherwise, it needs to be detected and reported as a problem. If a string is stored inside a variable, and then that variable is passed into Strings.Ignore, then it isn't ignored. "ldstr" should only be ignored if they're passed to the ignore method.

CA1707, CA1709, CA1028 on native enums

Mon, 26 Oct 2009 14:25:20 Z

Hi,

I am using a bunch of P/Invoke calls in my application for system functions such as CreateWindowEx, ... (for WPF HwndHost). Those API calls take a bunch of parameters, such as the window style, which are written as WS_VISIBLE (for example). So in my code I have these enum members, as written in the Microsoft Windows headers.

Unfortunately, FxCop fires CA1707 and CA1709 on these. For other false positives related to native interop, FxCop ignores them if they are in the NativeMethods class, but this isn't working for these false positives.

Also, I have my window styles enum of the base type uint. I took this from pinvoke.net. Is this correct? If it is, then the warning CA1028 also fires in error in this case, since I need this for native interop.

Will this be fixed in the future, or is the only way to ignore these warnings?

Kind regards,
Daniel Rose

Code analysis apis/tools

Mon, 26 Oct 2009 20:13:05 Z

FxCop and Visual Studio's Code Analysis are very nice tools but I'd like to perform my own static code analysis.

I am looking for apis/frameworks/... to programmatically inspect our .NET projects.
I'd like to write code able to do things like :

list methods which instantiate an object of class x
find methods containing a variable named x
list the callees of methods x
...

Just to be clear I am not looking for an existing tool such as FXCop but I am rather looking for some kind of api allowing me to perform whatever kind of static analysis I fancy.

Detecting Explicitly Declared Enum Values

Wed, 21 Oct 2009 12:50:01 Z

Hi,

I'm looking for a way to determine whether the values of an enumeration have been defined explicitly in code or assigned automatically by the compiler, for a rule that I'm writing to prevent explicit definitions of values unless they are powers of 2. Is there a way of detecting this case? I can't seem to find any property on the Field object that will help to determine this.

Thanks in advance,

Graham

CA1053 (Remove the public constructors from [className]) in test class...

Sun, 05 Nov 2006 18:36:59 Z

I have a class decorated with the [TestClass()] attribute. It was auto-generated by Visual Studio's unit testing framework. I'm getting a CA1053 error when I run code static analysis. Can this be fixed? Will it affect the unit testing generated code or render it unusable?

Thank you,
Sammy

CA1811, AvoidUncalledPrivateCode: Separate private & internal?

Wed, 21 Oct 2009 22:03:07 Z

I've been running FxCop on a managed assembly we build for a couple of days now, and something has struck me about the AvoidUncalledPrivateCode Performance rule. While it took me a bit to understand why internal members would be flagged alongside private members, I'm still left wondering if perhaps they shouldn't be separate rules.

To give some context, our project is a managed assembly that serves as an API for an unmanaged product. As such, there are a number of specific constructors and methods that have to be kept as internal-only, but serve a greater breadth of functionality within the library and can/will be used in the future. While I see the logic in flagging both types by this rule, in my context I would draw more of a distinction between internal and private class data and would prefer to flag one but not the other. Any thoughts on whether that would be a valid option, or is there some other reason I don't see as to why it would be prohibitive to flag one but not the other?

I realize it's probably nit-picking a bit, but I figured I'd ask. :-)

Thanks,
Mike

Can not switch Rule from error to warning

Tue, 22 Sep 2009 11:59:07 Z

Hi,
in the Code Analysis Editor I switch a rule from Error to warning ( unckeck Treat Warning as Error). All seems fine, if I build my solution locally on the Development PC. But if I run the same solution on the Build PC I get a build error for rule CA1709. But this rule is switech to warning.

c:\VLS\MainCIBuild\Sources\Main\Source\Vls\DP.Vls.Web\Shipment\Shipment.aspx.cs(86,0): error : CA1709 : Microsoft.Naming : Correct the casing of 'rcb' in member name 'Shipment.rcbReceiverAddressTypes_SelectedIndexChanged(object, RadComboBoxSelectedIndexChangedEventArgs)' by changing it to 'Rcb'.

Buildscript-Setting

RunCodeAnalysis>Default</RunCodeAnalysis>

Please help.

Regards Josef

eisisng

FxCop 1.36 Released!

Tue, 19 Aug 2008 20:41:53 Z

We've released FxCop 1.36. See the following for more information:

http://blogs.msdn.com/fxcop/archive/2008/08/19/fxcop-1-36-released.aspx

Applicatin Verifier - HighVersionLie and drvstore.dll

Fri, 16 Oct 2009 13:18:34 Z

Hi

I'm trying to pass my application thought MS Logo Toolkit. There was written that I have to have installed Application Verifier with it. But if there is AppVerifier than my application failed during installation. I reported this problem on Windows 7 Software Logo Program but I have no help from there.
https://connect.microsoft.com/feedback/ViewFeedback.aspx?FeedbackID=496156&SiteID=831

I will try explain what is problem. For replicate this bug you do not need my application just any driver which is not installed yet and pnputil.exe which is default MS tool for adding drivers into driver store on win vista and higher.

Here are steps to replicate this bug. I tested it on Win 7 32bit RTM

1. Run AppVerifier
2. Add C:\Windows\system32\pnputil.exe
3. Check Compatibility->HighVersionLie
4. Save

5. In Command line write e.g.: pnputil.exe /a C:\drivers\*.inf

What happen is that AppVerifier increase version of OS to check if tested application will work in future but pnputil.exe failed with error "The request is not supported." In setupapi.dev.log I can see what is problem
!!! sto: Using mismatched version 6.1.7600 drvstore.dll on version 7.0.8000 system. Error = 0x00000032

drvstore.dll have problem with higher version of OS. I don't know what to do with this. I'm stuck on this and I can not continue in obtaining Win 7 Logo.

Any suggestions, links, emails for solve this problem?
Thanks.