Warning "propertyAccessor != null" when using Expression<T> with generic base types

Question

Hi,

Using v 1.4.30903.0 and given the following interfaces:

public interface IBaseInterface<TId>
{
	string BaseProp { get; }
}

public interface IDerivedInterface : IBaseInterface<long>
{
	string DerivedProp { get; }
}

And a usage like:

Expression<Func<IDerivedInterface, object>> expression = x => x.BaseProp;

I receive a warning: "CodeContracts: requires unproven: propertyAccessor != null"

If I remove the generic parameter (TId) above, the warning goes away. Is this a known issue?

I saw a similar issue here: http://social.msdn.microsoft.com/Forums/en/codecontracts/thread/ddec1fc3-7047-4f78-bf15-4a2b2b1d7c22

But there was no specific mention of a generic parameter triggering the issue and it was also supposed to be resolved anyway

Cheers

 

 

 

Answer 1

I'm seeing the same issue.

Answer 2

I also experience this issue, but not with a generic interface (code contracts 1.4.40602)

public abstract class ObservableObject : DispatcherObject, INotifyPropertyChanged
{
        protected void NotifyPropertyChanged<T>(Expression<Func<T>> property)
        {
            Contract.Requires(property != null);

            // omitted for brevity
        }
}

Any reference to this in a derived class, e.g.

NotifyPropertyChanged(() => this.SomeSimpleProperty);

Will cause code contracts to raise a warning:

Warning 540 CodeContracts: requires unproven: propertyAccessor != null

It's quite an annoying one as this function is used all over our code and really don't want to have to suppress hundreds of calls only to later reinstate them.

Is there any confirmation of this as a defect, or a timescale?

Thanks,

Stephen

Answer 3

I would just like to find a way to suppress it. I asked a StackOverflow question about how to do that.

With the -outputwarnmasks flag in "Extra Static Checker Options" (on the Code Contracts tab of the project), I can see:

        add the attribute: [SuppressMessage("Microsoft.Contracts", "RequiresAtCall-propertyAccessor != null")] to the method System.Linq.Expressions.Expression.Property(System.Linq.Expressions.Expression,System.Reflection.MethodInfo)

But I obviously can't put the attribute there because that's in the Framework itself. If there were some other place to put that, I'd love to know.

Answer 4

This STILL is a problem with the latest release (1.4.51019.0)!

An official reaction to this would be most welcome.

I am seeing it in my FluentNhibernate auto-mapping overrides:

                          

    public class VatRateOverride : IAutoMappingOverride<VatRate>
    {
        public void Override(AutoMapping<VatRate> mapping)
        {
            Contract.Assume(mapping != null); 

            mapping.Id(x => x.Id).Column("VATVALUES_ID"); // <-- Here

        }
    }

Answer 5

Bump.

Please don't ignore this issue. It is a real show-stopper.

Answer 6

Can we please have some official feedback here? 1.4.60228.0 didn't fix this either.

At least I finally found a way to disable this warning. I am not sure if this is new in the latest release or not, but SuppressMessage actually does work. Putting the following attributes on the Override method I posted above gets rid of the warnings I get.

[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Contracts", "Nonnull", Justification = "Guaranteed to be not null.")]
[System.Diagnostics.CodeAnalysis.SuppressMessage("Microsoft.Contracts", "Requires", Justification = "Bug in static checker")]

Answer 7

Sorry for the long silence. We will take a look at

what is causing this.

---

Cheers, -MaF (Manuel Fahndrich)

Answer 8

Okay, I finally fixed this. It will be in the next release.

---

Cheers, -MaF (Manuel Fahndrich)

Answer 9

Thanks MaF,

I never posted in this thread, but was also affected by this issue, will be nice to have a clear output window.

Luke

Answer 10

Thanks! :)