Answered TFS code review check-in policy

  • Monday, March 19, 2012 7:53 AM
     
     
    Is there a way to force a code review for code being checked-in into the TFS service? I found some articles on custom check-in policies, but I guess those won't work on TFS preview. Which options are there?

    MCTS Web Application Development, SharePoint enthousiast.

All Replies

  • Monday, March 19, 2012 6:13 PM
    Owner
     
     
    At this point of time, we cannot do custom check-in policy for TFS Preview. Can you elaborate on your workflow to understand what you are looking for?
  • Monday, March 19, 2012 7:30 PM
     
     

    Sure, it's pretty simple. We would like each check-in to be reviewed by a second developer.

    To elaborate a bit more: we use the scrum board for task planning. Each developer handles tasks and drags those to 'in progress'. When a task is finished, we want a second developer to take a look at the code being checked in by the developer which handled the task. Not for extensive bugfixing or things like that, but to be certain there are at least two people who roughly know what's going on in that piece of code. The second developer might review the code and say: 'hey, this solution is ok, but there's an even better aproach!'. We hope to spread development knowledge faster that way.


    MCTS Web Application Development, SharePoint enthousiast.

  • Tuesday, March 20, 2012 5:50 PM
    Owner
     
     
    After talking to PG, it looks like custom Check-in policy don't need to be deployed on server, you can have it in client. Only thing you have to manage is deploying the policy on all the client.
  • Tuesday, March 20, 2012 6:51 PM
     
     
    Not sure what you mean. A custom policy on all development machines? I'm not sure if that's such a great solution. Do you have information on how to deploy this?

    MCTS Web Application Development, SharePoint enthousiast.

  • Wednesday, March 21, 2012 4:17 PM
    Owner
     
     Answered
    Please review http://blogs.msdn.com/b/jimpresto/ to start, and http://blogs.msdn.com/b/jimlamb/archive/2010/03/31/how-to-implement-package-and-deploy-custom-check-in-policy-for-tfs-2010.aspx

    Trevor Hancock (Microsoft)
    Please remember to "Mark As Answer" the replies that help.

  • Wednesday, March 21, 2012 6:06 PM
    Owner
     
     Answered

    As Trevor suggested, you can use that blog to create check-in policy and for distributing it to all clients, you can use TFS Powertool.Here is the link describing that.

    http://bartwullems.blogspot.com/2010/12/distributing-check-in-policies-across.html

    Hope this helps.

    Regards,

    Anjana