Syntax.ParseToken expected behavior is ambiguous for context sensitive keywords

Question

I expected Syntax.ParseToken("from") to return FromKeyword token not an identifier "from". If I want an identifier token then I'll call Syntax.Identifier.

Actually Roslyn should not have a Syntax.ParseToken as it's behavior is ambiguous for context senstive keywords. Instead, I Roslyn should partition keywords and provide parse functions for each family. E.g. ParseKeyword, ParseIdentifier, ParsePunctuation, etc. 

Thanks,
Chris

Answer 1

You can use Syntax.Token(SyntaxKind.FromKeyword) instead.

Answer 2

Svick, yeah, that's what I did but having one unambiguous API doesn't makeup for the ambiguous one. A C# ParseToken is context sensitive and the current API doesn't accept a context.

 

Answer 3

Thats a good suggestion Chris. I agree that the .ParseToken() API is confusing / ambiguous. Could you please log this suggestion via Connect? Alternately just let me know and I can log this internally on your behalf. Thanks!

---

Shyam Namboodiripad | Software Development Engineer in Test | Roslyn Compilers Team

Answer 4

Shyam,

Please log for me. Connect is of limited value to me because issues are closed before I consider them resolved. For example, my connect issue "ability to access private data members" was closed with a note that it was a good idea and pushed onto an internal backlog. Does that mean that it'll get done eventually or that it might get dropped? I don't know. And if the decision is made one way or another I won't know. 

So going forward please just open issues for me unless the connect policy changes. 

Thanks,
Chris